295 lesson7 #325
Merged
295 lesson7 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for parcel-pointers ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dankco
reviewed
Oct 18, 2023
| // ======================================= | ||
|
|
||
| .lesson7slides { | ||
| width: 55%; |
There was a problem hiding this comment.
Is there a reason for a width of only 55%? I would think it should take up more space.
Also, if you want to take a stab at fixing this image aspect ratio issue for different screen sizes, you can. This can be a separate ticket though.
There was a problem hiding this comment.
When there was no width the image would just be small unless I added the 55%, I think the image aspect ratio should be a separate ticket for now.
Dankco
approved these changes
Oct 18, 2023
Okay, I will work on the image issue. Thank you for all the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes:
Closes #211, #294, and #295
Screenshots