Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the active and hover button states for the check button #122

Conversation

shreyas61
Copy link
Collaborator

Summary

Closes #

Test Plan

@shreyas61 shreyas61 linked an issue Oct 24, 2024 that may be closed by this pull request
1 task
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for pen-pals ready!

Name Link
🔨 Latest commit 0b448a5
🔍 Latest deploy log https://app.netlify.com/sites/pen-pals/deploys/671b065ff390640008b62d95
😎 Deploy Preview https://deploy-preview-122--pen-pals.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shreyas61 shreyas61 requested a review from jpaten October 24, 2024 06:27
@shreyas61 shreyas61 self-assigned this Oct 24, 2024
@shreyas61 shreyas61 requested review from SanjnaT41756 and removed request for jpaten October 24, 2024 06:31
@shreyas61 shreyas61 removed their assignment Oct 24, 2024
@SanjnaT41756
Copy link
Contributor

Hi Shreya, great work so far! 😄

However, I have a couple of suggestions for improvement before merging these changes. If you hover and click on the "check" button, you can see the rest of the contents on the page shift for a moment, and we want to avoid this from happening.

To avoid this, I would like to suggest that you use the box-shadow property within the button's hover state. Similarly, look into the transform: scale property for the active state.

Additionally, in css/scss, if you are adding a variant/state (idk what its called lol) to an existing class object, then you do not need to copy over repeated properties.

For example, if you have:

#a-button {
  @include font-styles();
  background-color: colors.$primary-green;
  border: hidden;
  border-radius: 10px;
  color: colors.$text-white;
  padding: 1.25vw 2.5vw;
}

Then, you only need to add new properties into the hover state, rather than the same properties!

This is okay but its repitative

#a-button:hover {
  @include font-styles();
  background-color: colors.$primary-green;
  border: hidden;
  border-radius: 10px;
  color: colors.$text-white;
  padding: 1.25vw 2.5vw;

  box-shadow: 0 0 0rem black;
}

This is better! The properties of a-button are going to still apply!

#a-button:hover {
  **box-shadow: 0 0 0rem black;**
}

Let me know if you have any questions! 🌸

shreyas61 and others added 3 commits October 24, 2024 14:42
Copy link
Contributor

@SanjnaT41756 SanjnaT41756 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@SanjnaT41756 SanjnaT41756 merged commit 8027020 into main Oct 25, 2024
6 checks passed
@SanjnaT41756 SanjnaT41756 deleted the 119-minor-update-add-styling-to-check-button-in-unit-circle-level branch October 25, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐾 Minor Update: Add styling to check button in Unit Circle Level
2 participants