-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the active and hover button states for the check button #122
Added the active and hover button states for the check button #122
Conversation
✅ Deploy Preview for pen-pals ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi Shreya, great work so far! 😄 However, I have a couple of suggestions for improvement before merging these changes. If you hover and click on the "check" button, you can see the rest of the contents on the page shift for a moment, and we want to avoid this from happening. To avoid this, I would like to suggest that you use the Additionally, in css/scss, if you are adding a variant/state (idk what its called lol) to an existing class object, then you do not need to copy over repeated properties. For example, if you have:
Then, you only need to add new properties into the hover state, rather than the same properties! This is okay but its repitative
This is better! The properties of
Let me know if you have any questions! 🌸 |
…ions. Used box-shaow, added transform.
…ow to hover, used transform and made box-shadow hidden for active.
…-in-unit-circle-level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Summary
Closes #
Test Plan