Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1299 alexj boat drone comms #1304

Merged
merged 18 commits into from
Dec 31, 2024
Merged

1299 alexj boat drone comms #1304

merged 18 commits into from
Dec 31, 2024

Conversation

alexoj46
Copy link
Contributor

Description

This PR creates a ROSSerialDevice called DroneCommDevice which allows Navigator to communicate with the drone. Also, it adds a test-suite for simulated packets.

Screenshot or Video

Screenshot 2024-10-30 at 7 25 36 PM Screenshot 2024-10-30 at 11 57 08 PM

Related Issues

- #1299

Testing

rosrun navigator_drone_comm test_simulated_drone.py

  • This starts the test program.
  • You should see a received GPSDronePacket and TargetPacket printed to the console immediately.

While "Testing receiving heartbeats for 5 secs..."

  • You should see no outputted errors for missing heartbeat.

While the long test loop runs

  • You should see error for no received heartbeat every second.
  • Use ctrl Z to end execution.

To test services that send messages:

  • Comment out lines in driver.py with “send_packet()”.
  • Uncomment the print statements next to those lines.
  • Now instead of freezing after sending packets, you will see print statements when messages would be sent to the drone.

Now, while the long test runs:

  • Call the services below in a separate terminal to check that a message would be sent.
  • Use ctrl c to end execution early.

rosservice call /test_simulated_drone/start “sample_mission”
rosservice call /test_simulated_drone/estop
rosservice call /test_simulated_drone/stop

About This PR

  • I have updated documentation related to this change so that future members are aware of the changes I've made.

@cbrxyz
Copy link
Member

cbrxyz commented Dec 20, 2024

@alexoj46 Do you remember if you were able to upload all the changes for this off from the boat/your computer? The last commit was at 11:04AM on the day the drone took a swim... :(

I'm happy to take a look whenever, but if there's still stuff to pull off the boat, I'll hold off until after break!

@alexoj46
Copy link
Contributor Author

@cbrxyz This seems to be the most up to date version of what ended up working on the boat. I can't quite remember if there were any bugs that needed fixing after handling merge conflicts on the boat, but I believe it was relatively straightforward.

@cbrxyz
Copy link
Member

cbrxyz commented Dec 27, 2024

awesome thank u for the update alex, i'll make sure to review this soon then! <3

@cbrxyz cbrxyz self-requested a review December 27, 2024 23:51
@cbrxyz
Copy link
Member

cbrxyz commented Dec 31, 2024

Looks good! I'm going to go through and make some small changes and then approve!

cbrxyz
cbrxyz previously approved these changes Dec 31, 2024
Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you alex! amazing job!!

@uf-mil-bot
Copy link
Collaborator

uf-mil-bot commented Dec 31, 2024

Hola, your friendly InvestiGator bot here with another message!

Because this PR was closed/merged, I'm going to remove the docs preview for now.

Have a great day! Go gators! 🐊

@cbrxyz cbrxyz merged commit 2891c36 into master Dec 31, 2024
7 checks passed
@cbrxyz cbrxyz deleted the 1299-alexj-boat-drone-comms branch December 31, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants