-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1299 alexj boat drone comms #1304
Conversation
…nto 1299-alexj-boat-drone-comms
@alexoj46 Do you remember if you were able to upload all the changes for this off from the boat/your computer? The last commit was at 11:04AM on the day the drone took a swim... :( I'm happy to take a look whenever, but if there's still stuff to pull off the boat, I'll hold off until after break! |
@cbrxyz This seems to be the most up to date version of what ended up working on the boat. I can't quite remember if there were any bugs that needed fixing after handling merge conflicts on the boat, but I believe it was relatively straightforward. |
awesome thank u for the update alex, i'll make sure to review this soon then! <3 |
Looks good! I'm going to go through and make some small changes and then approve! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you alex! amazing job!!
Hola, your friendly InvestiGator bot here with another message! Because this PR was closed/merged, I'm going to remove the docs preview for now. Have a great day! Go gators! 🐊 |
Description
This PR creates a ROSSerialDevice called DroneCommDevice which allows Navigator to communicate with the drone. Also, it adds a test-suite for simulated packets.
Screenshot or Video
Related Issues
- #1299
Testing
rosrun navigator_drone_comm test_simulated_drone.py
While "Testing receiving heartbeats for 5 secs..."
While the long test loop runs
To test services that send messages:
Now, while the long test runs:
rosservice call /test_simulated_drone/start “sample_mission”
rosservice call /test_simulated_drone/estop
rosservice call /test_simulated_drone/stop
About This PR