Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for component NoahMP land model #2387

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from

Conversation

uturuncoglu
Copy link
Collaborator

@uturuncoglu uturuncoglu commented Aug 2, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

The PR aims to bring recent updates from component land model. The major changes are,

  • Add new decomposition algorithm to NoahMP component model NUOPC cap to distribute land and ocean points evenly to all the processor. The new decomposition algorithm might be more efficient especially for high resolution cases. The new decomposition algorithm can be activated by adding decomp_type = custom option to LND_attributes:: section of ufs.configure.
  • A new flux calculation method is implemented in CCPP/Physics sfc_land scheme to overcome initialization issues. We also adjust run sequences of land related configurations.
  • New RTs based on S2S configurations are introduced and they include extra component as land. The new tests called as cpld_control_p8_lnd and control_restart_p8_atmlnd.
  • The atm-lnd side-by-side RT (control_p8_atmlnd is removed since CCPP/Physics version of the code diverged from the component model. Some of the information provided by the CCPP/Physics can not be provided in the component model. For example, update for land IAU in the ccpp-physics NoahMP. The side-by-side run can be still performed by running control_p8_atmlnd or cpld_control_p8_lnd by setting cpllnd2atm = .false.. This will turn off feedback from land component to atmospheric model and allow atmospheric model receive land fluxes from CCPP/Physics version of NoahMP.
  • The issues in atm-lnd configuration related with the inconsistent input files are solved by using input files form coupled configuration.

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP -
  * WW3 - 
  * stochastic_physics - 

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
    Two new RTs are added: cpld_control_p8_lnd and control_restart_p8_atmlnd
    One RT is removed: control_p8_atmlnd_sbs
  • PR Updates/Changes Baselines.
    All land related RTs have answer changes due to the changes in the input files and also change the way of model initialization.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@uturuncoglu
Copy link
Collaborator Author

@junwang-noaa I created a draft PR to bring recent updates from land side and I'll keep working on it. Once it is ready, I'll change it's status. Probably, this would be the last update from land JTTI project since we are plaining to finalize it around end of August.

@DeniseWorthen
Copy link
Collaborator

@uturuncoglu Does this PR require an ESMF update for the "stripes" fix?

@uturuncoglu
Copy link
Collaborator Author

@DeniseWorthen No, I put a fix in CMEPS side, now it uses redist rather then interpolation (see the CMEPS PR for more detail). Since we are using same grid in both land and atmosphere that works for the RTs. CMEPS is assuming they are using same grid by default. Once we want to run land in a tiger resolution under S2S configuration, then we need newer version of ESMF that has fix.

@DeniseWorthen
Copy link
Collaborator

Thanks for the explanation. What about LM4?

@uturuncoglu
Copy link
Collaborator Author

@DeniseWorthen LM4 has no fully coupled configuration yet and it is only coupled with DATM. So, it won't affect it. But, I still need to add samegrid_atmlnd=.false. to also those tests since mediator mainly assumes that atmosphere and land grids are same which is not correct for data atmosphere could configurations.

@uturuncoglu uturuncoglu marked this pull request as ready for review January 3, 2025 20:58
@uturuncoglu
Copy link
Collaborator Author

@jkbk2004 @junwang-noaa @DeniseWorthen @barlage It was waiting in draft mode for a long time but now this PR is ready to go. I have just sync all the submodules. We are just expecting answer change for land related configurations. You could find more information in the PR description.

@uturuncoglu
Copy link
Collaborator Author

BTW, testing is done on Hercules using Intel compiler. All RTs are fine except land related ones which are expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atm-Lnd tests are not using V2 surface files
2 participants