-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for component NoahMP land model #2387
base: develop
Are you sure you want to change the base?
Updates for component NoahMP land model #2387
Conversation
@junwang-noaa I created a draft PR to bring recent updates from land side and I'll keep working on it. Once it is ready, I'll change it's status. Probably, this would be the last update from land JTTI project since we are plaining to finalize it around end of August. |
@uturuncoglu Does this PR require an ESMF update for the "stripes" fix? |
@DeniseWorthen No, I put a fix in CMEPS side, now it uses redist rather then interpolation (see the CMEPS PR for more detail). Since we are using same grid in both land and atmosphere that works for the RTs. CMEPS is assuming they are using same grid by default. Once we want to run land in a tiger resolution under S2S configuration, then we need newer version of ESMF that has fix. |
Thanks for the explanation. What about LM4? |
@DeniseWorthen LM4 has no fully coupled configuration yet and it is only coupled with DATM. So, it won't affect it. But, I still need to add |
@jkbk2004 @junwang-noaa @DeniseWorthen @barlage It was waiting in draft mode for a long time but now this PR is ready to go. I have just sync all the submodules. We are just expecting answer change for land related configurations. You could find more information in the PR description. |
BTW, testing is done on Hercules using Intel compiler. All RTs are fine except land related ones which are expected. |
Commit Queue Requirements:
Description:
The PR aims to bring recent updates from component land model. The major changes are,
decomp_type = custom
option toLND_attributes::
section ofufs.configure
.sfc_land
scheme to overcome initialization issues. We also adjust run sequences of land related configurations.cpld_control_p8_lnd
andcontrol_restart_p8_atmlnd
.control_p8_atmlnd
is removed since CCPP/Physics version of the code diverged from the component model. Some of the information provided by the CCPP/Physics can not be provided in the component model. For example, update for land IAU in the ccpp-physics NoahMP. The side-by-side run can be still performed by runningcontrol_p8_atmlnd
orcpld_control_p8_lnd
by settingcpllnd2atm = .false.
. This will turn off feedback from land component to atmospheric model and allow atmospheric model receive land fluxes from CCPP/Physics version of NoahMP.Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Two new RTs are added:
cpld_control_p8_lnd
andcontrol_restart_p8_atmlnd
One RT is removed:
control_p8_atmlnd_sbs
All land related RTs have answer changes due to the changes in the input files and also change the way of model initialization.
Input data Changes:
Library Changes/Upgrades:
Testing Log: