Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotool fixes #24

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Autotool fixes #24

wants to merge 6 commits into from

Conversation

shenki
Copy link

@shenki shenki commented May 8, 2014

These changes allow the autoreconf step of building the Git tree run without warnings on a modern Linux system. I tested on Ubuntu Trusty (14.04) amd64.

These are the minimal fixes required to remove the warnings.

shenki added 6 commits May 8, 2014 22:24
When running autoreconf, we get several million warnings about
subdir-objects being disabled.

 src/Makefile.am:40: but option 'subdir-objects' is disabled
 src/Makefile.am:40: warning: source file 'feld/FeldModern8-14.cxx' is in
 a subdirectory,

Signed-off-by: Joel Stanley <[email protected]>
The following warning is silenced by defining a gettext version. I
arbitrarily chose 0.14 as it's old and should be sufficient for our needs.

 autoreconf: configure.ac: AM_GNU_GETTEXT is used, but not
 AM_GNU_GETTEXT_VERSION

Signed-off-by: Joel Stanley <[email protected]>
The following warning (which was repeated several times) is now
resolved:

  configure.ac:184: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call
  detected in body
  ../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
  ../../lib/autoconf/general.m4:2661: _AC_LINK_IFELSE is expanded from...
  ../../lib/autoconf/general.m4:2678: AC_LINK_IFELSE is expanded from...
  ../../lib/m4sugar/m4sh.m4:639: AS_IF is expanded from...
  ../../lib/autoconf/general.m4:2748: AC_RUN_IFELSE is expanded from...
  m4/tls.m4:2: CHECK_TLS is expanded from...
  m4/tls.m4:56: AC_FLDIGI_TLS is expanded from...
  configure.ac:184: the top level

Signed-off-by: Joel Stanley <[email protected]>
Most of the targets in our makefiles contain the following warning:

  src/Makefile.am:265: warning: call silent,GUIDE ,$@: non-POSIX variable
name
  src/Makefile.am:265: (probably a GNU make extension)

For now, silence it by introducing -Wno-portability to the options, as
it didn't appear to be hurting anybody.

Signed-off-by: Joel Stanley <[email protected]>
These files are generated by the build process and therefore should not
be checked in.

Signed-off-by: Joel Stanley <[email protected]>
Sort them by alphabetical order while we're here.

Signed-off-by: Joel Stanley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant