-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 修复开启 styleLoader 和 cssLoader 的 sourceMap 后, js 文件会暴露 css 源码的问题 #11417
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
LGTM |
Size Change: +61 B (0%) Total Size: 10.1 MB
ℹ️ View Unchanged
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #11417 +/- ##
=======================================
Coverage 29.03% 29.04%
=======================================
Files 484 484
Lines 14667 14670 +3
Branches 3459 3459
=======================================
+ Hits 4259 4261 +2
- Misses 9657 9658 +1
Partials 751 751
☔ View full report in Codecov by Sentry. |
如果没有显示定义 当使用者需要 source map 时,我们不能偷偷把 source map 去了,这会导致用户丢失 css 的映射。 故这个改动我认为是不清真的,建议转做:
|
|
开启 styleLoader 和 cssLoader 的 sourceMap 后:
判断开启 styleLoader 和 env === production 时,将 cssLoader 的 sourceMap 关闭后: