fix: Fix webworker not working #12795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
稍等我试试看能不能补充一个 example |
Wxh16144
commented
Nov 20, 2024
Comment on lines
+27
to
+43
| module._cachedGeneratedCode = `__webpack_require__.p = (function(){ | ||
| // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis | ||
| function __check(it) { | ||
| return it && it.Math === Math && it; | ||
| }; | ||
|
|
||
| var __global =( | ||
| __check(typeof globalThis == 'object' && globalThis) || | ||
| __check(typeof window == 'object' && window) || | ||
| __check(typeof self == 'object' && self) | ||
| ); | ||
|
|
||
| if(__global && __global.publicPath) return __global.publicPath; | ||
|
|
||
| // fix: https://github.com/umijs/umi/issues/12781 | ||
| return ${JSON.stringify(compilation.outputOptions.publicPath || '/')}; | ||
| })();`; |
There was a problem hiding this comment.
还有一个需要确认的是，这段代码会增加构建后的产物，__check 是否可以去掉？
先决条件： 1. qiankun 项目 2. publicpath 非 '/‘
ready~ |
|
还有其他人能看下？ |
Closed
|
@Wxh16144 能换个其他人 review 吗？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12781
原因是 worker 环境中， globalThis 和 宿主的不是同一个，不能直接使用。多加一层判断。
先决条件：