Unfork mitm by using another workaround #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, Cool! Nice that we can get the surface area down. Once question though, rather than shift around that huge block fo code, could we take the opportunity to just have it as a |
|
You're welcome to do that! It's not really a huge piece of code that can be shared, so I didn't feel it was a necessity. |
|
@alexjeffburke, we can also merge this as-is and do further refactorings separately? |
|
Yeah, go for it and get a patch release out :) |
|
Released in 13.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the suggestion posted here to avoid maintaining a fork of the mitm module.
Most of the diff is due to prettier's reformatting, so I recommend ignoring whitespace changes when viewing it.