Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to download and install binary language files for spell checker #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blipk
Copy link

@blipk blipk commented Aug 16, 2024

This script downloads and installs the binary dictionary files that ungoogled chromium uses for its spell checking feature.

It will look for both OS install and Flatpak install config directories and installs to both/either of them if they exist.

A custom install directory can also be specified.

Currently only works on Linux.

Adapted from the instructions in the FAQ here:
https://ungoogled-software.github.io/ungoogled-chromium-wiki/faq#how-do-i-fix-the-spell-checker

This PR is based on the recommendation here:
ungoogled-software/ungoogled-chromium#188 (comment)

@PF4Public
Copy link
Contributor

Brief description and usage examples are in the top of the script, looks good. @networkException do you have any comments?

@networkException
Copy link
Member

Well I would not try to parse Gitiles' HTML but rather just access the repository using git but otherwise looks good

@blipk
Copy link
Author

blipk commented Aug 17, 2024

@networkException

I looked at using gitpython but it complicates the script a lot more, have to (shallow) clone the repo, set up temporary directories etc

It is also a lot slower.

requests and beautifulsoup are generally more available than gitpython as well: https://piptrends.com/compare/gitpython-vs-beautifulsoup4-vs-requests

@blipk
Copy link
Author

blipk commented Aug 17, 2024

There was also some discussion here about just including the dictionary files (or downloading and generating them in your build process): ungoogled-software/ungoogled-chromium#188

Searching my home directory it seems other GPL/MIT/Apache licenced software includes the binary .bdic files without problem e.g. VSCodium, drawio, heroic launcher etc

@PF4Public
Copy link
Contributor

binary .bdic

Remember, we have a script to specifically prune all binaries :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants