-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-18108 Give all languages a primary script: trivial cases #4210
CLDR-18108 Give all languages a primary script: trivial cases #4210
Conversation
docs/site/development/updating-codes/update-language-script-info/language-script-description.md
Outdated
Show resolved
Hide resolved
Thanks for all your work on this... We are getting some long-needed
improvements!
…On Wed, Nov 20, 2024, 18:09 Conrad Nied ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In common/supplemental/supplementalData.xml
<#4210 (comment)>:
> @@ -1712,6 +1717,7 @@ XXX Code for transations where no currency is involved
<language type="ilo" territories="PH" alt="secondary"/>
<language type="inh" scripts="Cyrl"/>
<language type="inh" scripts="Arab Latn" territories="RU" alt="secondary"/>
+ <language type="io" scripts="Latn" alt="secondary"/>
This is auto-generated. TBH I don't understand why the ConvertLanguageData
script did this for this entry but not others -- I suspect because its
missing territory data. I'll have to edit ConvertLanguageData.
—
Reply to this email directly, view it on GitHub
<#4210 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMG5IQOY5XFXEUYP6RT2BU6GJAVCNFSM6AAAAABSFQTMH2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJQGA3TGNJRGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
3cb6b86
to
7f653f7
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
I think we should put this on hold for now, and focus on https://unicode-org.atlassian.net/browse/CLDR-18087. |
191c88d
to
fd262df
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
fd262df
to
7b4a73a
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but i see there's other discussion
docs/site/development/updating-codes/update-language-script-info/language-script-description.md
Outdated
Show resolved
Hide resolved
I can hold off on this change -- but I want to close out easy tickets rather in parallel with working on the more complex ones. |
This change adds "primary" scripts to many languages in language_script.tsv. This won't change likely subtags, rather this just future-proofs our data by recognizing a singular primary script, avoiding issues where ambiguities served customers the wrong script. I also added scripts for languages in country_language_population.tsv that were missing.
Updated the ConvertLanguageData script to avoid demoting historical scripts/historical langauges. Also removed multi-primary script notes from the description -- anticipating a re-design, handled by other tasks.
mvn spotless:apply
`und` -> `Latn` makes sense in many context, but `Zyyy` (Undetermined) may make sense as well. To avoid unanticipated side-effects, let's remove this row and only add it in if we need it.
7b4a73a
to
630e20a
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
As discussed in the Unicode CLDR Design meeting, let's move ahead with the straightforward updates -- and work on the long-term changes in parallel. Many of the long-term changes require larger refactors so I think we should still merge this change so the data quality improves incrementally, rather than large / hard to review changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken links otherwise OK
We should make sure this goes in the release notes under migration
docs/site/development/updating-codes/update-language-script-info/language-script-description.md
Outdated
Show resolved
Hide resolved
docs/site/development/updating-codes/update-language-script-info/language-script-description.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Steven R. Loomis <[email protected]>
Co-authored-by: Steven R. Loomis <[email protected]>
docs/site/development/updating-codes/update-language-script-info/language-script-description.md
Outdated
Show resolved
Hide resolved
…e-script-info/language-script-description.md Co-authored-by: Mark Davis <[email protected]>
This change adds "primary" scripts to many languages in language_script.tsv.
This won't change likely subtags, rather this just future-proofs our data by recognizing a singular primary script, avoiding issues where ambiguities served customers the wrong script.
I also added scripts for languages in country_language_population.tsv that were missing.
CLDR-18108
There are many more tasks, especially more complicated ones, in the parent ticket https://unicode-org.atlassian.net/browse/CLDR-18102
ALLOW_MANY_COMMITS=true