Handle subnet list #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
disaac
commented
Jul 27, 2017
disaac
commented
- Removed packer/terraform dir in env.docker since this is no longer needed.
- Removed packer_tasks from the Rakefile since this was also deprecated in the latest covalence.
- subnets should be receieved as a list type already so can be passed directly without placing inside another list.
- subnets should be receieved as a list type already so can be passed directly without placing inside another list.
- Removed packer/terraform dir in env.docker since this is no longer needed. - Removed packer_tasks from the Rakefile since this was also deprecated in the latest covalence.
**NOTE: This would be a breaking change for usage of this module with a comma separated string list.
```
["${split(",",var.subnet_ids)}"]
```
To convert to a list would fail since it would already be of type list.
|
@disaac would this break compatibility with previous versions due to the change in the subnet input data type? If so, would you mind tagging this separately with the appropriate version bump? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.