fix(oci): Don't delete dependencies of index #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we package an application it can be the case that we have a dependency on another package (e.g. a kernel). In these cases, the dependency is not actually packed together with our application, instead we just keep a reference to it. The problem arises when we attempt to overwrite such a package. Because all dependencies were previously deleted, this meant that both of the underlying packages would be removed, but only the application would get repackaged, resulting in an app that cannot be run due to missing layers. Setting this flag to false and not removing dependencies solves this issue, but causes the cache to grow indefinitely, which is less than ideal. Signed-off-by: Luca Seritan <[email protected]>
|
I opened #1639 to track the implementation of a garbage collection mechanism that will fix the indefinite growth of the cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we package an application it can be the case that we have a dependency on another package (e.g. a kernel). In these cases, the dependency is not actually packed together with our application, instead we just keep a reference to it. The problem arises when we attempt to overwrite such a package. Because all dependencies were previously deleted, this meant that both of the underlying packages would be removed, but only the application would get repackaged, resulting in an app that cannot be run due to missing layers.
Setting this flag to false and not removing dependencies solves this issue, but causes the cache to grow indefinitely, which is less than ideal.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes