Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Makefile): Enable verbose Go builds #1646

Merged
merged 1 commit into from
May 13, 2024

Conversation

nderjung
Copy link
Member

The build can take up to two minutes, and this is also helpful
when you often recompile to see what was changed.

Signed-off-by: Alexander Jung [email protected]

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

The build can take up to two minutes, and this is also helpful
when you often recompile to see what was changed.

Signed-off-by: Alexander Jung <[email protected]>
Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu [email protected]
Approved-by: Cezar Craciunoiu [email protected]

@craciunoiuc craciunoiuc merged commit 06b44da into unikraft:staging May 13, 2024
10 checks passed
nderjung added a commit to nderjung/kraftkit that referenced this pull request May 13, 2024
The PR unikraft#1630 accidentally overwrote the changes from unikraft#1646.

This commit reverts this mistake.

Signed-off-by: Alexander Jung <[email protected]>
@nderjung nderjung mentioned this pull request May 13, 2024
4 tasks
nderjung added a commit to nderjung/kraftkit that referenced this pull request May 13, 2024
…#1646.

This commit reverts this mistake.

Signed-off-by: Alexander Jung <[email protected]>
nderjung added a commit to nderjung/kraftkit that referenced this pull request May 13, 2024
The PR unikraft#1630 accidentally overwrote the changes from unikraft#1646.

This commit reverts this mistake.

Signed-off-by: Alexander Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants