Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(initrd): Enable writing hardlinks for dockerfiles #1978

Merged

Conversation

craciunoiuc
Copy link
Member

@craciunoiuc craciunoiuc commented Nov 26, 2024

By counting files and mapping inodes we guarantee
that hardlinks are properly created from tar files.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

@craciunoiuc craciunoiuc requested a review from nderjung November 26, 2024 16:34
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/bump-golang-1.23.3 branch 4 times, most recently from e85a04e to 95947db Compare November 27, 2024 09:39
go.mod Show resolved Hide resolved
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, other than that, looks good, thanks! (also go.mod needs update)

By counting files and mapping inodes we guarantee
that hardlinks are properly create from tar files.

Signed-off-by: Cezar Craciunoiu <[email protected]>
Also bump across files.

Signed-off-by: Cezar Craciunoiu <[email protected]>
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/bump-golang-1.23.3 branch from 95947db to 177865f Compare December 5, 2024 09:27
@craciunoiuc craciunoiuc merged commit 24c50fd into unikraft:staging Dec 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants