-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Qrack from source on build #3
Conversation
I tried running
|
Likely, the issue is that, before packaging, you need to run these two commands, first, to pull in Qrack and Catalyst:
When the source package builds, the necessary files will end up copied over directly into the source package, so PyPi install doesn't need the submodules. Just a "packaging environment" does. |
Sorry for the "noise" in the diff from running |
For that, don't we need to add qrack url in https://github.com/unitaryfund/pennylane-qrack/blob/qrack_source_install/.gitmodules ? |
Explicitly add Qrack to .gitmodules
I think the answer is actually, "It's optional," because the command line tools didn't do it automatically in this case, while the submodule was successfully added, but I just made it explicit in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor changes, but aside from the LGTM!)
@cosenal To the point of your comment elsewhere, you asked about examples we could run to show the package works, and I actually ran into an issue with even static linkage of the Qrack library when I attempted to run the Everyone be aware, you will have to install Qrack separately, currently. On the bright side, the Python package installation will complain that the |
In theory, Qrack has a perfectly "sane and rational" set of various supported methods by which users can install it; in practice, this a large cognitive load on users who just want the Python package from PyPi. Hence, this PR adds an automatic Qrack source checkout and build for the Catalyst device, such that no manual installation of Qrack by the user is necessary to install the Catalyst Qrack device package from PyPi.