Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Dummy allocation' for Catalyst #5

Merged
merged 1 commit into from
Jun 3, 2024
Merged

'Dummy allocation' for Catalyst #5

merged 1 commit into from
Jun 3, 2024

Conversation

WrathfulSpatula
Copy link
Collaborator

Lightning devices for Catalyst appear not to parse the logical qubit WireMap, but rather allocate as device qubit indices, solely. However, it seems that if theWireMap is parsed in the QrackDevice constructor, then QrackDevice can serve up the correct arbitrary WireMap labels for logical qubits, as Catalyst requests and expects them.

@WrathfulSpatula WrathfulSpatula requested a review from vprusso June 3, 2024 20:39
vprusso
vprusso approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (minor comment, but you can feel free to ignore!)

pennylane_qrack/qrack_device.cpp Show resolved Hide resolved
@WrathfulSpatula WrathfulSpatula merged commit f100c29 into master Jun 3, 2024
4 checks passed
@WrathfulSpatula WrathfulSpatula deleted the catalyst_workaround branch June 3, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprusso vprusso vprusso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WrathfulSpatula @vprusso