more new YAMLs and tweaks #1565
Conversation
some to try rectify the false negatives of Thanks You pages not being recognised.
|
Check out the conflicts? Also, for that, finds really help before the success step |
|
Sorry! will fix. re: removing the find command, we found that if we gave the thank you page time to load then looked for body content we were getting more reliable success readings. Otherwise we were getting an error on the find - presumedly b/c the page hadn't loaded fast enough for us to find anything. It could be put back in after the 20 sec wait as an extra step if it would help but didnt seem necessary. |
|
May come down to different phantom versions or whatever you're using to fill these out I guess, but for us anyway, if regular success is false negativing, find usually fixes it (occasionally find + wait) |
We were able to improve our implementation of the find to handle the issue rather than remove it so put these back in.
now fixed!
|
Still some conflicts, but also not super keen on merging these Senate ones (minus maybe Crapo, if you've had good experience with it). All of the others are working virtually 100% here, and your changes (removing finds, mainly) will cause them to error more. |
|
Noting here that you're going to get a certain amount of random error, even with YAMLs that are perfectly constructed, at least we do with phantom, time outs, etc... We rerun failed jobs every day and that usually pushes this up towards 100% territory. Is this something you already do? |
|
re: removing finds - agreed, i'm reversing those changes our end too. re: occasional intermittent issues yes our strategy is to re-try them also |
|
Ok, left some comments. Can we revert all the Senate changes? None of them are substantive and all the Senate YAMLs are currently working well under high volume according to our system. And there's some merge errors in there. I commented the lines. But happy to merge the house ones! |
| - click_on: | ||
| - value: Submit | ||
| selector: input.btn | ||
| - find: |
There was a problem hiding this comment.
think this is unnecessary, works without for almost all, can get others on retry
| - click_on: | ||
| - value: Send | ||
| selector: "#side-search-btn" | ||
| - find: |
There was a problem hiding this comment.
let's keep the find, works with it very well
| - find: | ||
| - selector: h1 | ||
| value: Thank you for emailing | ||
| ======= |
There was a problem hiding this comment.
this one has a merge error and is working fine with no changes, let's revert this whole change
| selector: "input.btn[value='Submit']" | ||
| - wait: | ||
| - value: 3 | ||
| - find: |
There was a problem hiding this comment.
let's keep the find, working great with it
| - find: | ||
| - value: Thank You | ||
| selector: h1 | ||
| ======= |
There was a problem hiding this comment.
merge error here, and working fine with no changes, let's revert this change
| - visit: http://www.heinrich.senate.gov/contact/write-martin | ||
| - select: | ||
| - name: topic | ||
| selector: '#contactForm select[name=''topic'']' |
There was a problem hiding this comment.
bad syntax here, and generally these changes are unnecessary as this form is working great, can we revert?
| ''); | ||
| - javascript: | ||
| - value: document.querySelector('#side-search-btn').click(); | ||
| - find: |
There was a problem hiding this comment.
unnecessary changes as this one works fine, revert?
| selector: input.btn | ||
| - wait: | ||
| - value: 3 | ||
| - find: |
There was a problem hiding this comment.
find instead of wait if we can, this works great with find and is faster
| - value: document.querySelector("#message").value = document.querySelector("#message").value.replace(/"/g, ''); | ||
| - click_on: | ||
| - value: Send My Message | ||
| selector: "#side-search-btn" |
There was a problem hiding this comment.
works great without find, let's revert
| - click_on: | ||
| - value: Submit | ||
| selector: input.btn | ||
| ======= |
some to try rectify the false negatives of Thanks You pages not being
recognised.