optscript: bug fix, new operators, refactoring #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
The original code updates only the lineNumber member of the tag entry. Signed-off-by: Masatake YAMATO <[email protected]>
_tagloc takes a corkQueue index and pushes a mloc object locating the tag object identified by the corkQueue index. Signed-off-by: Masatake YAMATO <[email protected]>
… notation Signed-off-by: Masatake YAMATO <[email protected]>
forall operators has array, dict, and string backends. Unify the similar code in the backends into one. Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
The original code has code a bug; the inputStart and inputEnd events propagate only to direct sub parsers. Thes event never propagate to sub sub parsers. This change fixe this. The events are propagated recursively in base/sub parser relations. The ways to run prelude/sequel codes and propagate inputStart/End events are unified. As the result a optlib parser running as a sub parser of another optlib parser can run its prelude/sequel codes. Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
… the window Signed-off-by: Masatake YAMATO <[email protected]>
…om the window Signed-off-by: Masatake YAMATO <[email protected]>
…efintions A for loop was used for the iteration. The original code used XTAG_COUNT as the limit of the loop counter. However, the contestant doesn't consider dynamically allocated parser-specific xtags. The new code uses countXtags() that considers dynamically allocated parser-specific xtags. Signed-off-by: Masatake YAMATO <[email protected]>
…hooks Signed-off-by: Masatake YAMATO <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3028 +/- ##
========================================
Coverage 87.32% 87.32%
========================================
Files 199 199
Lines 47450 47595 +145
========================================
+ Hits 41434 41564 +130
- Misses 6016 6031 +15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation pull request for mering #3027.
The last commit of #3027 includes a critical bug. So the running the test cases fails.
This pull requests includes all commits other than the last one.
All changes are useful even if we don't merge #3027.