Folia support #73
Open
Folia support #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `MinecraftBukkitScheduler` class to handle task scheduling and cancellation - Introduce `SchedulerTask` interface to represent scheduled tasks - Update `HoloEasy` class to include scheduler binding - Add `SchedulerRunnable` abstract class for scheduling runnable tasks - Define `MinecraftScheduler` interface for task scheduling and cancellation
|
Its possibile to create two modules, a spigot and a folia ? Each depending on the holoeasy-core module |
It is, but I don't find the reason to tbh. |
# Conflicts: # buildSrc/src/main/kotlin/buildlogic.java-conventions.gradle.kts # gradle/libs.versions.toml # holoeasy-core/src/main/kotlin/org/holoeasy/HoloEasy.kt # holoeasy-core/src/main/kotlin/org/holoeasy/animation/Animations.kt # holoeasy-core/src/main/kotlin/org/holoeasy/line/ILine.kt # holoeasy-core/src/main/kotlin/org/holoeasy/pool/HologramPool.kt # holoeasy-core/src/main/kotlin/org/holoeasy/util/BukkitFuture.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the HoloEasy library with support for the Folia scheduler.
Changes Made:
Implementation Details:
To use the Folia scheduler implementation, please include the following dependencies in your
build.gradle.kts:dependencies { implementation("com.github.GeorgeV220.holoeasy:holoeasy-core:6e6d70b6d8") { setTransitive(false) } implementation("com.github.GeorgeV220.holoeasy:holoeasy-folia:6e6d70b6d8") { setTransitive(false) } }(replace georgev22 with unlenis when you merge it for the docs)
Testing:
I recommend testing the library in your own Minecraft environment.
In Folia everything worked (using the packetevents example plugin/my own plugin)
Please confirm that the implementation works as expected before merging.
Library Compiles Successfully
Ensure the library compiles without errors in the default build environment.
Published Successfully to JitPack
Confirm the library can be published to JitPack without issues.
Resolvable from JitPack
Test that the library can be imported as a dependency in another project through JitPack, verifying both its presence and proper version resolution.
Builds Without Issues in Downstream Projects
Integrate the library into at least one downstream project to confirm it compiles and works as expected when added as a dependency.
Functionality Works In-Game as Expected
Test the library in an actual game environment to ensure features function as intended, with all core features stable and without bugs.