RBT-274 Load process rearranged #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail-iurkov
force-pushed
the
cleanup/loading
branch
from
461cb2e to
965ba90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5 (review)
extract_tiff_data- Extracts TIFF bytes from given image (was_ExifReaderfactory method)TiffReader- Reads IFD frombytes(_ExifReader, with non-tag agnostic parts moved toExifLoader)ExifLoader- Assembles EXIF by IFDs . Filters known tags, coerces values (tag dependent parts ofExifLoader+load)load- wrapper aroundExifLoaderandextract_tiff_dataChanged
read_unknown=True- now it's returned same way as known tags. Tags with unknown type are discarded anyway.Checklist