Typescript patches #255
Merged
Typescript patches #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse-engineer and fix type type problems: DialogApi: fileColl: FileInfo[] => CollectionOfPromises<FileInfo>; The fileColl property is not an array of file infos. It is a collection of promises that resolve to file infos when they are uploaded. This is initialized here: https://github.com/uploadcare/uploadcare-widget/blob/1b33ac45986bffeb311bdb1293170b3925932aa1/src/widget/dialog.js#L265 ```javascript // files collection this.files = new CollectionOfPromises(files) ``` Second, FileUpload is cancelable. This is added in uploadcare-widget: https://github.com/uploadcare/uploadcare-widget/blob/1b33ac45986bffeb311bdb1293170b3925932aa1/src/files/base.js#L230 ```javascript api.cancel = this.__cancel.bind(this) ```
FileInfo: the uuid/mimeType can both be null for new files when the validator is invoked
…a FileGruop. The difference being a promise that resolves to a FileGroup vs a FileGroup
nd0ut
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR for #253
This fixes a few of issues with the type definitions in this project. I inferred most of these fixes by debugging and reverse engineering the types.
A couple notable ones:
Without the types being exported, its hard to write typed functions, so FileGroup is now exported
Checklist