Skip to content

Commit

Permalink
Update test matrix and update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
vipulnsward committed Mar 2, 2024
1 parent 6c7ce2a commit 1e3b875
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
- 3.0
- 3.1
- 3.2
- 3.3
runs-on: ubuntu-latest
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
Expand All @@ -25,16 +26,14 @@ jobs:
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true # runs bundle install and caches installed gems automatically
cache-version: 20231016
- run: bundle exec rake

code-analysis:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version:
- 3.1
- 3.2
- 3.3
steps:
- uses: actions/checkout@v4
- name: Set up Ruby
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Fixed

* Documentation issue with `uploadcare_include_tag`
* Drop support for Ruby < 3.x

## 3.3.4 — 2023-04-04

Expand Down
4 changes: 2 additions & 2 deletions lib/uploadcare/rails/active_record/mount_uploadcare_file.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ def mount_uploadcare_file(attribute)
end

unless Uploadcare::Rails.configuration.do_not_store
after_save "uploadcare_store_#{attribute}!".to_sym, if: "will_save_change_to_#{attribute}?".to_sym
after_save :"uploadcare_store_#{attribute}!", if: :"will_save_change_to_#{attribute}?"
end

return unless Uploadcare::Rails.configuration.delete_files_after_destroy

after_destroy "uploadcare_delete_#{attribute}!".to_sym
after_destroy :"uploadcare_delete_#{attribute}!"
end
# rubocop:enable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def mount_uploadcare_file_group(attribute)
Uploadcare::GroupApi.store_group(group_id)
end

after_save "uploadcare_store_#{attribute}!".to_sym unless Uploadcare::Rails.configuration.do_not_store
after_save :"uploadcare_store_#{attribute}!" unless Uploadcare::Rails.configuration.do_not_store
end
# rubocop:enable Metrics/MethodLength
end
Expand Down

0 comments on commit 1e3b875

Please sign in to comment.