Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support params in Rest client and in file info method. #151

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

vipulnsward
Copy link
Collaborator

@vipulnsward vipulnsward commented Feb 24, 2024

Description

  • Fix Uploadcare::Param::SecureAuthHeader to allow accepting query params that can be passed down to http requests
  • Add make_uri method to support the same, with or without query params options being passed down
  • Group and move call method to class << self instead
  • In RestClient start passing down params when calling api struct request
  • Start passing down params from info method to get
  • Cover with new specs

Closes #132

Checklist

- Fix Uploadcare::Param::SecureAuthHeader to allow accepting query params that can be passed down to http requests
- Add make_uri method to support the same, with or without query params options being passed down
- Group and move call method to class << self instead
- In RestClient start passing down params when calling api struct request
 - Start passing down params from info method to get
 - Cover with new specs
@vipulnsward vipulnsward merged commit 0eda04b into main Feb 24, 2024
12 checks passed
@vipulnsward vipulnsward deleted the gh-132 branch February 24, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response to Uploadcare::File.file("FILE_ID_IN_YOUR_PROJECT") doesn't include appdata
1 participant