Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new AuthError class for raising authentication related issues when public/private keys are empty. Closes #158 #161

Merged
merged 4 commits into from
Apr 7, 2024

Conversation

vipulnsward
Copy link
Collaborator

Description

Checklist

…en calculating auth header params, start raising an error if any or public or secret key is blank in auth config. Add file client specs to verify the same. Add authentication header specs to for verifying the params validation
… check to is_empty? check. Also check that value is nil or not and not just empty. Add file client spec validation for the same.
…blank? and not blank? to not be confused with the more popular Object#blank? method in Rails
@vipulnsward vipulnsward merged commit 57bce87 into main Apr 7, 2024
10 checks passed
@vipulnsward vipulnsward deleted the gh-158 branch April 7, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library calculates request signature even if no secret key provided
1 participant