Fix that Signed urls did not work with nth notation for groups as well as when using ~ in URLs #174
Conversation
…l as when using ~ in urls. Add proper escaping for the same
WalkthroughThis update enhances the URL sanitization mechanism in the Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- lib/uploadcare/signed_url_generators/akamai_generator.rb (1 hunks)
- spec/uploadcare/signed_url_generators/akamai_generator_spec.rb (1 hunks)
Additional comments not posted (4)
lib/uploadcare/signed_url_generators/akamai_generator.rb (2)
38-40: LGTM! Path sanitization added.The
build_aclmethod now correctly sanitizes paths using thesanitized_delimiter_pathmethod.
44-47: LGTM! Path sanitization implemented.The
sanitized_delimiter_pathmethod correctly replaces the~character with its hexadecimal representation.spec/uploadcare/signed_url_generators/akamai_generator_spec.rb (2)
58-65: LGTM! Group URL generation tests added.The tests correctly validate URL generation for groups.
67-74: LGTM! Nth file type notation tests added.The tests correctly validate URL generation for nth file type notation within a group.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[duplication] ~8-~8: Possible typo: you repeated a word
Context: ...ocumentConverter#convert` options. ### Fixed * Fixed that signed URLs now work with ~ in the...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~13-~13: Possible typo: you repeated a word
Context: ...file URLs. ## 4.4.2 — 2024-05-29 ### Fixed * Fixed theUploadcare::File.remote_copymeth...(ENGLISH_WORD_REPEAT_RULE)
Additional comments not posted (3)
CHANGELOG.md (3)
9-9: LGTM!The changelog entry is clear and concise.
10-10: Fix possible repeated word.There is a potential typo: the word "that" is repeated. Consider revising the sentence for clarity.
- * Fixed the `Uploadcare::File.remote_copy` method which raised an `ApiStruct::EntityError: {url} must be Hash`. Now returns a string instead of a `File` entity instance. + * Fixed `Uploadcare::File.remote_copy` method which raised an `ApiStruct::EntityError: {url} must be Hash`. Now returns a string instead of a `File` entity instance.Likely invalid or redundant comment.
8-8: Fix possible repeated word.There is a potential typo: the word "that" is repeated. Consider revising the sentence for clarity.
- * Fixed that signed URLs now work with ~ in the path. This also fixes signed URLs with grouped file URLs. + * Fixed signed URLs to work with ~ in the path. This also fixes signed URLs with grouped file URLs.Likely invalid or redundant comment.
Tools
LanguageTool
[duplication] ~8-~8: Possible typo: you repeated a word
Context: ...ocumentConverter#convert` options. ### Fixed * Fixed that signed URLs now work with ~ in the...(ENGLISH_WORD_REPEAT_RULE)
Description
Fix that Signed urls did not work with nth notation for groups as well as when using ~ in URLs
Closes #167 #138
Checklist
Summary by CodeRabbit
Bug Fixes
~correctly.New Features