Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch to playwright image (and python3.10) #15

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Conversation

uptickmetachu
Copy link
Contributor

@uptickmetachu uptickmetachu commented Apr 18, 2024

Changes:

  • Adds playwright to the build (Increases image size to 2GB :()
  • Adds browser_url option for browser based rendering of a remote url
  • Adds renderer option (takes prince or playwright). When rendering browser_url playwright is used to fetch html and then feed into prince
  • Adds browser_headers option. A mapping of str->str for additional browser headers when viewing a page. Useful for browser based authentication.
  • Adds ./splat_cli.py which can be used to invoke the dockerised splat lambda (or url) and generate pdfs. Useful for comparing princexml and playwright renderers.

Copy link
Contributor

@bayangan1991 bayangan1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see any issues here.

Would be good to see a demo of it working if you have a chance

@uptickmetachu uptickmetachu merged commit 9278343 into master Apr 29, 2024
1 check passed
@uptickmetachu uptickmetachu deleted the feat/spray branch April 29, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants