Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-4552 feat(playwright): add browser launch kwargs #23

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

bayangan1991
Copy link
Contributor

Add an option to supply arguments to the browser launch process.

This is done so that we can specify the LANGUAGE environment variable so playwright renders datetimes correctly

Jira

@bayangan1991 bayangan1991 force-pushed the feat/browser-launch-kwargs branch from 018b689 to d8bf769 Compare October 21, 2024 05:24
Copy link
Contributor

@uptickmetachu uptickmetachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fingers crossed.

@uptickmetachu uptickmetachu merged commit 265303a into master Oct 21, 2024
1 check passed
@uptickmetachu uptickmetachu deleted the feat/browser-launch-kwargs branch October 21, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants