This repository has been archived by the owner on Apr 24, 2019. It is now read-only.
Add a modules folder for all components on a page #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually you want to develop components for your website or app which should ideally be bundled into one directory. This commit adds a directory `modules` for all these modules and updates according configuration for Karma and the build process. Reference: #123
|
Thanks, works fine here. I wonder if we should allow html to be in there, too (for consistency mainly)? But to be honest I don't think people would use this approach for HTML and you'll always will have some generic html elsewhere. What do you think? |
|
I think it would be very nice to have HTML in this folder. Care to create a PR? |
|
I could easily do but earliest by tomorrow (don't have any time today unfortunately). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually you want to develop components for your website or app which
should ideally be bundled into one directory. This commit adds a
directory
modulesfor all these modules and updates accordingconfiguration for Karma and the build process.
Reference: #123
Please have a detailed look if this makes a) sense to you and b) works as expected.