Verifiable builds section #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkymanOne
requested review from
cmichi,
ascjones and
DoubleOTheven
as code owners
cmichi
requested changes
Oct 4, 2023
Comment on lines
84
to
86
| If you are using standardized verifiable builds. It is your responsibility | ||
| to ensure deterministic environment both for build and verification of | ||
| smart contracts. |
There was a problem hiding this comment.
Suggested change
| If you are using standardized verifiable builds. It is your responsibility | |
| to ensure deterministic environment both for build and verification of | |
| smart contracts. | |
| If you are using standardized verifiable builds (i.e. the contract was built with | |
| `cargo contract build --verifiable`, it is your responsibility to ensure a deterministic | |
| environment both for build and verification of smart contracts. |
@SkymanOne Is this how you meant it?
There was a problem hiding this comment.
Sorry, it is a typo
Yes, as part of 4.0.0-alpha |
Co-authored-by: Michael Müller <[email protected]>
Co-authored-by: Michael Müller <[email protected]>
Co-authored-by: Michael Müller <[email protected]>
Co-authored-by: Michael Müller <[email protected]>
SkymanOne
commented
Oct 4, 2023
Co-authored-by: Michael Müller <[email protected]>
cmichi
reviewed
Oct 24, 2023
| "basics/verification/sirato" | ||
| ] | ||
| } | ||
| // "basics/verification", |
There was a problem hiding this comment.
Suggested change
| // "basics/verification", |
cmichi
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99