Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): settings must have a defined value #1508

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

saeta-eth
Copy link
Contributor

This PR aims to fix a bug where settings could be defined without a value. Previously, we didn’t catch this, resulting in default values being used instead of throwing an error.

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 054beb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saeta-eth saeta-eth marked this pull request as ready for review October 29, 2024 14:05
@mjlescano
Copy link
Member

@dbeal-eth for this one we needed for you to set the missing settings on snx deployment files, to avoid breakages and to be able to run our tests successfully 🙏

@saeta-eth
Copy link
Contributor Author

This PR is quite important to be released as soon as possible by the way.

Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test to confirm the specific case that this fix is applying for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants