Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some wording in documentation related to Drupal automatic updates #3729

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bryangruneberg
Copy link
Contributor

  • Simple fix
  • PR title should be good for release notes

@bomoko
Copy link
Contributor

bomoko commented May 26, 2024

I'm trying to see if this change is true - I can't quite tell if we've done any work on Lagoon itself to disable automatic updates, or if it's just updated when lagoon integrations is installed (see #3504)

@@ -23,7 +23,7 @@ The following update methods been disabled by Lagoon.
## Drupal Automatic Updates

The [Automatic Updates](https://www.drupal.org/project/automatic_updates)
contrib module is disabled by and it will also be disabled when it moves
contrib module is disabled by Lagoon. The module will also be disabled when it moves
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I meant to say "disabled by default." We will use an environment variable to disable, so users would be able to override that if they want (for example, using/testing automatic updates locally).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably explain here how it is disable - what the variable is, and where it is set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants