Refactor 28 generic s3 #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
requested changes
Apr 7, 2022
2 tasks
src/Storage/Device/BackBlaze.php
Outdated
| @@ -2,9 +2,10 @@ | |||
|
|
|||
| namespace Utopia\Storage\Device; | |||
|
|
|||
| use Utopia\Storage\Device\S3; | |||
| use Utopia\Storage\Device\Generic; | |||
There was a problem hiding this comment.
We should have a better name for Generic?
Can we use S3 as base instead of creating new Generic?
There was a problem hiding this comment.
S3 is also one of Generic child's.
Can be S3Base? or S3Compatible
There was a problem hiding this comment.
What's the difference in S3 itself and Generic? if there is a difference then yes Generic can S3Base - S3Base sounds more reasonable than S3Compatible.
Co-authored-by: Matej Bačo <[email protected]>
…ctor-28-genericS3
2 tasks
|
@christyjacob4, is this still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.