Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code quality analysis with PHPStan #62

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abhishekdd
Copy link
Contributor

Closes 🔎 Add Code Analyzer To ‘utopia-php/storage’ #4374

Implements code quality analysis into the repository. This allows running composer check to check for errors. Also auto-checks every PR with composer check to create failed test if there are code quality issues.

This PR also fixes the code quality issues identified by PHPStan up to analysis level 5.

Add code quality analysis with PHPStan and GitHub workflow to be triggered on pull request.
Fixed code quality issues up to level 5.
@christyjacob4
Copy link
Contributor

Please sync your branch with main . It has fixes for the failing CI tests

@stnguyen90 stnguyen90 self-requested a review October 28, 2022 22:37
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhishekdd would you please sync with main and fix the merge conflicts?

@PineappleIOnic
Copy link
Member

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@christyjacob4 christyjacob4 marked this pull request as ready for review February 20, 2023 06:36
@christyjacob4 christyjacob4 self-requested a review April 6, 2023 08:56
@christyjacob4
Copy link
Contributor

@abhishekdd thanks a lot for your contributions during Hacktoberfest 2022!

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

@stnguyen90
Copy link
Contributor

@abhishekdd would you be able to fix the merge conflicts so we can merge this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔎 Add Code Analyzer To ‘utopia-php/storage’
4 participants