-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Exoscale adapter #99
base: main
Are you sure you want to change the base?
Add Exoscale adapter #99
Conversation
@stnguyen90 Can you review this PR? |
Can this PR be reviewed? So that the necessary changes can be done by me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! 🤯 We left some comments during the review, please check them out.
Please make sure to run the formatter to fix the lint errors and attach screenshots of successful tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments.
In addition, please fix the lint errors and attach a screenshot of successful tests to the PR.
Co-authored-by: Steven Nguyen <[email protected]>
@stnguyen90 I have referred the configuration from https://community.exoscale.com/documentation/storage/quick-start/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to run the formatter to fix the lint errors and attach screenshots of successful tests.
Co-authored-by: Luke B. Silver <[email protected]>
Where is the formatter ? |
You can see the errors under the 'Checks' tab. To run the formatter do Please try to consult the CONTRIBUTING.md if you are stuck |
Hello @Atharva1723 Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. Looking forward to your updates and thank you! |
I am working on the PR rn will commit the changes as soon as possible.. |
I have run the formatter. |
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
@gewenyu99 Here is my Discord username:
.please let me know if you are not able to reach out to me via discord.Thank You 😄 |
Adding your name to a big spreadsheet to reach out. Thanks for your patience! |
I have completed the partial implementation of the Exoscale adapter . Please review the PR and let me know what changes need to be made.
Related issue: