This repository has been archived by the owner on May 10, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Correctly handle mouse event submission (fixes #29) #30
Open
uuf6429
wants to merge
6
commits into
master
Choose a base branch
from
Correctly-handle-mouse-event-submission
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuf6429
force-pushed
the
Correctly-handle-mouse-event-submission
branch
3 times, most recently
from
May 12, 2017 06:57
fdaf91c
to
32664d0
Compare
uuf6429
commented
May 21, 2017
src/Server/Server.js
Outdated
); | ||
}) | ||
.catch(function (error) { | ||
Logger.error('Could create mouse event listener (%j): %s', params, errorToString(error)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not create
uuf6429
force-pushed
the
Correctly-handle-mouse-event-submission
branch
from
May 23, 2017 22:56
835fdff
to
f918e87
Compare
uuf6429
force-pushed
the
Correctly-handle-mouse-event-submission
branch
from
May 26, 2017 16:18
f918e87
to
5d5916c
Compare
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
============================================
+ Coverage 82.65% 83.11% +0.46%
+ Complexity 160 159 -1
============================================
Files 3 3
Lines 467 462 -5
============================================
- Hits 386 384 -2
+ Misses 81 78 -3 |
uuf6429
force-pushed
the
Correctly-handle-mouse-event-submission
branch
from
May 27, 2017 19:59
5d5916c
to
e6675bc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.