docs: Create unit glossary #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added units to the docstrings * style: pre-commit fixes * Adding another file * Made changes to the docstrings * style: pre-commit fixes * Made the changes, fixed indentation * style: pre-commit fixes * Added spacing, fixed indentation, added unitless * Made changes and adjusted the spacing * style: pre-commit fixes * docs: Updated units and formatting including cosmology, lenses, and sources * fix: Removed tuple and moved returns * fix: Remove tuple from return and moved separated returns * style: pre-commit fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: uwcdc <[email protected]>
* Added units to the docstrings * style: pre-commit fixes * Adding another file * Made changes to the docstrings * style: pre-commit fixes * Made the changes, fixed indentation * style: pre-commit fixes * Added spacing, fixed indentation, added unitless * Made changes and adjusted the spacing * style: pre-commit fixes * docs: Updated units and formatting including cosmology, lenses, and sources * fix: Removed tuple and moved returns * fix: Remove tuple from return and moved separated returns * style: pre-commit fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: uwcdc <[email protected]>
* made changes to units based on suggestions * style: pre-commit fixes * Update src/caustics/lenses/pixelated_convergence.py Co-authored-by: Cordero Core <[email protected]> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Cordero Core <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## glossary #90 +/- ##
===========================================
Coverage ? 92.41%
===========================================
Files ? 40
Lines ? 2135
Branches ? 0
===========================================
Hits ? 1973
Misses ? 162
Partials ? 0 ☔ View full report in Codecov by Sentry. |
uwcdc
requested changes
Mar 5, 2024
There was a problem hiding this comment.
@RashmikaReddy You need to add the glossary to the _toc.yml file, so you can view it from the rendered JupyterBook. You can use this link to see how it should be updated.
You can access the current _toc.yml file here
I would recommend adding it after the - file: modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.