Correct top songs retrieval and add test

uxmp · Nov 20, 2022 · b2fbf98 · b2fbf98
1 parent c09b7d9
commit b2fbf98
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 6 deletions.
diff --git a/src/Orm/Repository/SongRepository.php b/src/Orm/Repository/SongRepository.php
@@ -108,15 +108,17 @@ public function getTopSongsByArtist(
             WITH pbh.song_id = song.id
             WHERE song.artist = :artist
             GROUP BY song HAVING(pbh.id) > 0
-            ORDER BY COUNT(pbh.id)
+            ORDER BY COUNT(pbh.id) DESC
             SQL;
 
         return $this->getEntityManager()
-            ->createQuery(sprintf(
-                $query,
-                Song::class,
-                PlaybackHistory::class,
-            ))
+            ->createQuery(
+                sprintf(
+                    $query,
+                    Song::class,
+                    PlaybackHistory::class,
+                )
+            )
             ->setParameters(['artist' => $artist])
             ->setMaxResults(10)
             ->toIterable();

diff --git a/tests/Orm/Repository/SongRepositoryTest.php b/tests/Orm/Repository/SongRepositoryTest.php
@@ -17,9 +17,11 @@
 use Mockery;
 use Mockery\Adapter\Phpunit\MockeryTestCase;
 use Mockery\MockInterface;
+use Uxmp\Core\Orm\Model\ArtistInterface;
 use Uxmp\Core\Orm\Model\CatalogInterface;
 use Uxmp\Core\Orm\Model\Favorite;
 use Uxmp\Core\Orm\Model\FavoriteItemTypeEnum;
+use Uxmp\Core\Orm\Model\PlaybackHistory;
 use Uxmp\Core\Orm\Model\Song;
 use Uxmp\Core\Orm\Model\SongInterface;
 use Uxmp\Core\Orm\Model\UserInterface;
@@ -218,4 +220,55 @@ public function testFindFavoritesReturnsData(): void
             $this->subject->findFavorites($user, $catalog)
         );
     }
+
+    public function testGetTopSongsByArtistReturnsSongs(): void
+    {
+        $query = $this
+            ->getMockBuilder(AbstractQuery::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['getResult', 'setParameters', 'toIterable'])
+            ->addMethods(['setMaxResults'])
+            ->getMockForAbstractClass();
+        $artist = Mockery::mock(ArtistInterface::class);
+
+        $result = [Mockery::mock(SongInterface::class)];
+
+        $sql = <<<SQL
+            SELECT song
+            FROM %s song
+            LEFT JOIN %s pbh
+            WITH pbh.song_id = song.id
+            WHERE song.artist = :artist
+            GROUP BY song HAVING(pbh.id) > 0
+            ORDER BY COUNT(pbh.id) DESC
+            SQL;
+
+        $this->entityManager->shouldReceive('createQuery')
+            ->with(
+                sprintf(
+                    $sql,
+                    Song::class,
+                    PlaybackHistory::class,
+                )
+            )
+            ->once()
+            ->andReturn($query);
+
+        $query->expects($this->once())
+            ->method('setParameters')
+            ->with(['artist' => $artist])
+            ->willReturnSelf();
+        $query->expects($this->once())
+            ->method('setMaxResults')
+            ->with(10)
+            ->willReturnSelf();
+        $query->expects($this->once())
+            ->method('toIterable')
+            ->willReturn($result);
+
+        $this->assertSame(
+            $result,
+            $this->subject->getTopSongsByArtist($artist)
+        );
+    }
 }