Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use podman mount instead of podman cp #240

Closed
wants to merge 1 commit into from
Closed

Use podman mount instead of podman cp #240

wants to merge 1 commit into from

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Apr 12, 2024

What does this PR change?

podman cp seems to have some limitations. Using podman mount + cp + podman umount does the same thing but probably more reliably.

Test coverage

  • No tests: commands executed are not yet unit asserted

Links

Issue(s): #

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

podman cp seems to have some limitations. Using podman mount + cp +
podman umount does the same thing but probably more reliably.
@cbosdo cbosdo requested a review from mbussolotto April 12, 2024 14:41
Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbosdo
Copy link
Contributor Author

cbosdo commented Apr 15, 2024

Too many side effects, dropping

@cbosdo cbosdo closed this Apr 15, 2024
@cbosdo cbosdo deleted the cp-rework branch April 15, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants