Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing localization strings #246

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Add missing localization strings #246

merged 1 commit into from
Apr 17, 2024

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Apr 17, 2024

What does this PR change?

Add missing strings and regex checks

Test coverage

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • DONE

Links

Issue(s): #

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

@cbosdo cbosdo requested a review from nadvornik April 17, 2024 12:03
Copy link
Contributor

@nadvornik nadvornik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbosdo cbosdo merged commit 1c27fac into main Apr 17, 2024
6 checks passed
@cbosdo cbosdo deleted the l10n-fixes branch April 17, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants