Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous {{end}} in post upgrade template #250

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Remove extraneous {{end}} in post upgrade template #250

merged 1 commit into from
Apr 18, 2024

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Apr 18, 2024

What does this PR change?

Fix runtime panic:

panic: template: script:18: unexpected {{end}}

goroutine 1 [running]:
text/template.Must(...)
        /usr/lib64/go/1.21/src/text/template/helper.go:26
github.com/uyuni-project/uyuni-tools/mgradm/shared/templates.PostUpgradeTemplateData.Render({{0x8e118b?, 0x241?}}, {0x9a6ae0, 0xc0003aa098})
        /home/abuild/rpmbuild/BUILD/uyuni-tools-git-24.1c27fac/mgradm/shared/templates/postUpgradeScriptTemplate.go:39 +0x173
github.com/uyuni-project/uyuni-tools/shared/utils.WriteTemplateToFile({0x9a79a0, 0xc00038e8b0}, {0xc000396540, 0x25}, 0x396526?, 0xc0?)
        /home/abuild/rpmbuild/BUILD/uyuni-tools-git-24.1c27fac/shared/utils/template.go:36 +0x1b7

Test coverage

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • DONE

Links

Issue(s): #

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

@cbosdo cbosdo requested a review from mbussolotto April 18, 2024 07:19
@cbosdo cbosdo merged commit 35346d9 into main Apr 18, 2024
6 checks passed
@cbosdo cbosdo deleted the end-fix branch April 18, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants