Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask confirmation before importing gpg key #264

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

mbussolotto
Copy link
Member

What does this PR change?

ask confirmation before importing gpg key

Test coverage

  • No tests
  • DONE

Links

Issue(s): #

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

@mbussolotto mbussolotto requested review from cbosdo and rjmateus April 22, 2024 16:30
@mbussolotto mbussolotto marked this pull request as ready for review April 22, 2024 16:31
@mbussolotto
Copy link
Member Author

if you want to have a look at the library I used https://github.com/manifoldco/promptui.

shared/utils/utils.go Outdated Show resolved Hide resolved
mgradm/cmd/gpg/add/gpg.go Outdated Show resolved Hide resolved
@mbussolotto mbussolotto force-pushed the gpg branch 2 times, most recently from 72ebead to db13a40 Compare April 24, 2024 12:44
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a wording suggestion.

mgradm/cmd/gpg/add/gpg.go Outdated Show resolved Hide resolved
Co-authored-by: Cedric Bosdonnat <[email protected]>
@cbosdo cbosdo merged commit 82719e3 into uyuni-project:main Apr 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants