Dev container with vscode configuration #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbussolotto
changed the title
mbussolotto
force-pushed
the
main
branch
5 times, most recently
from
0910aa6 to
3742f22
Compare
mbussolotto
changed the title
cbosdo
reviewed
Nov 8, 2024
cbosdo
reviewed
Nov 19, 2024
| ] | ||
| } | ||
| }, | ||
| "postCreateCommand": "curl -fLo \"${XDG_DATA_HOME:-$HOME/.local/share}\"/nvim/site/autoload/plug.vim --create-dirs https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim && echo \"alias vim='nvim -u .devcontainer/init.vim'\" >> ~/.bashrc && nvim -u ${containerWorkspaceFolder}/.devcontainer/init.vim +PlugInstall +qall && cd ${containerWorkspaceFolder} && go mod download && pre-commit install-hooks && ./install-hooks.sh" |
There was a problem hiding this comment.
Funny that you install nvim there... how comes?
There was a problem hiding this comment.
I installed nvim with my init.vim file.. in this way running devcontainer exec --workspace-folder=. /bin/bash I can use vim and have exactly the same vim as I have in my host machine :) I hope it might help to use just devcontainer than host machine
cbosdo
approved these changes
Nov 19, 2024
mbussolotto
force-pushed
the
main
branch
3 times, most recently
from
8e84b91 to
d498012
Compare
rjpmestre
reviewed
Nov 19, 2024
fix
rjpmestre
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
I discover that it's possible to run devcontainer using CLI: so devcontainer up --workspace-folder=. then devcontainer exec --workspace-folder=. /bin/bash and you would have a container with everything setup...also the vim plugin for working with golang
Test coverage
No tests
DONE
Links
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!