Fix NoClassDefFoundError when opening notifications #7556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested tests to cover this Pull Request
|
mcalmer
approved these changes
Sep 17, 2023
|
@HoussemNasri can you rebase this branch on top of current master. I think some of the SonarCloud errors will go away. |
HoussemNasri
force-pushed
the
fix-notification-error
branch
from
86ac473 to
f15265b
Compare
|
SonarCloud is not complaining anymore, but one cucumber test failed. |
That is a known race condition. I rerun the test. Likely it will succeed this time. |
mcalmer
approved these changes
Sep 25, 2023
|
@mcalmer Rerunning did the job, all checks have passed now. Any other changes to add to the PR? |
|
master branch is currently "blocked" as we try to release uyuni 2023.09. As soon as it is opened again, I can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
The problem is that
Class#forNamecan throw aLinkageErrororExceptionInInitializerErrorwhich wouldn't be caught by the current catch statement. Eventually, sinceconfigureMailer()is called during class initialization, the exception will be caught by the classloader and translated intoNoClassDefFoundError. However, I still don't know why exactly an Error was thrown in the first place nor I can reproduce the other behaviors reported like the WebUI not responding.To reproduce, replace the content of
configureMailer()withthrow new LinkageError();, and then try to visit the notifications page. In the logs, you'll get a similar exception to what was reported in the linked issue. One difference is that the exception starts fromprepareUserNotificationsnotdataUnread.GUI diff
No difference.
Documentation
No documentation needed.
DONE
Test coverage
No tests.
DONE
Links
Fixes #6918
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: