Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate the correct file path for deb repo metadata (bsc#1214982) #7566

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

lucidd
Copy link
Member

@lucidd lucidd commented Sep 20, 2023

What does this PR change?

susemanager generated dep repos contain channel specific path as part of package metadata which makes it not reusable and our current caching mechanism to produce wrong metadata. This PR tries to retain the speedup of the cached result while also regenerating the Filename field to fix the issue. Long term we should change the way we generate deb repos to package metadata is channel independent.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • No tests

  • DONE

Links

https://github.com/SUSE/spacewalk/pull/22542

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@lucidd lucidd requested a review from a team as a code owner September 20, 2023 15:03
@lucidd lucidd requested review from cbbayburt and removed request for a team September 20, 2023 15:03
@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request

@lucidd lucidd merged commit e696376 into master Oct 5, 2023
13 checks passed
@lucidd lucidd deleted the bsc1214982-uyuni branch October 5, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants