-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and remove systemd use in the setup scripts #9508
base: master
Are you sure you want to change the base?
Conversation
Maybe whole |
f2a1d06
to
98b2fde
Compare
The merge of this PR has to be synchronized with uyuni-project/uyuni-tools#507 |
I have the feeling that the whole |
I think so. I never understood how it should work, so we never used it |
98b2fde
to
b893de7
Compare
44145bb
to
61144c4
Compare
Remove unused code in the setup scripts in order to ease refactoring them. This commit removes the need for systemd running as PID1 to run the setup script. This also means that mgr-setup has to be called before running the real container and starting everything. Note that some of the cleanup removing non-SUSE distributions handling, which shouldn't be a problem as Uyuni is now only shipped as a container built on a single openSUSE distro.
61144c4
to
cfb6ca8
Compare
Build tested in OBS and deployment working with the kubernetes operator. |
What does this PR change?
Remove unused code in the setup scripts in order to ease refactoring them. This commit removes the need for systemd running as PID1 to run the setup script.
This also means that mgr-setup has to be called before running the real container and starting everything.
Note that some of the cleanup removing non-SUSE distributions handling, which shouldn't be a problem as Uyuni is now only shipped as a container built on a single openSUSE distro.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
CI needs to be adjusted
DONE
Links
Issue(s): #
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!