Server image cleanup #9577
Server image cleanup #9577
Conversation
|
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
OBS cannot handle folders as sources, compress a folder named root in the container folder into a root.tar.gz before pushing to OBS.
cbosdo
force-pushed
the
server-image-cleanup
branch
from
f5671f0 to
57ada03
Compare
In order to remove the repositories from the container image the testsuite needs to stop relying on sumaform to add any package like expect.
In order to remove the need to install OpenIPMI in the server container, prepare a container image to run the fake IPMI server.
cbosdo
force-pushed
the
server-image-cleanup
branch
from
57ada03 to
9b032f1
Compare
| node = get_target('server') | ||
| mgrctl = node.has_mgrctl ? 'mgrctl' : '' |
There was a problem hiding this comment.
It was a bit hard to understand the first time that I read it :)
But ok.
(I like the approach on the expect files, as this way we can keep the source code aligned between 4.3 and 5.0)
There was a problem hiding this comment.
Just maybe, we can reduce one line by directly using true/false values coming from node.has_mgrctl instead of mapping those to 'mgrctl'/''.
But a matter of taste.
There was a problem hiding this comment.
I'm not an expert in expect syntax. I can try your suggestion, I have no clue if that will be properly interpreted.
What does this PR change?
Reduce the number of unneeded layers by grouping the RUN commands and all the files in an ADD from a tarball.
Also remove depending on packages added in the container by the CI to allow removing the repos from the image.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: cucumber tests changed
DONE
Links
Issue(s): #
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!