Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase clock tick time to fix local failure #8429

Closed
wants to merge 1 commit into from

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jan 2, 2025

Description

Increased the fake clock tick time from 150ms to 200ms to fix the test failure, which apparently happens only locally:

➜  web-components git:(main) ✗ yarn test --group field-base
yarn run v1.22.19
$ web-test-runner --group field-base

packages/field-base/test/field-mixin.test.js:

 ❌ FieldMixin + Polymer > error message > announcements > should not announce error message when field is valid
      AssertionError: expected 'This field is required' to equal ''
      + expected - actual

      -This field is required

      at n.<anonymous> (packages/field-base/test/field-mixin.test.js:185:47)

Chromium: |██████████████████████████████| 14/14 test files | 672 passed, 1 failed, 4 skipped

Finished running tests in 6s with 1 failed tests.

Type of change

  • Internal

Copy link

sonarqubecloud bot commented Jan 2, 2025

@vursen vursen requested a review from web-padawan January 2, 2025 10:42
@vursen vursen marked this pull request as ready for review January 2, 2025 10:45
@vursen vursen requested a review from DiegoCardoso January 2, 2025 11:01
@vursen vursen closed this Jan 2, 2025
@vursen
Copy link
Contributor Author

vursen commented Jan 2, 2025

This change already found its way to the main branch through #8430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant