Revert "feat: add locale i18n property, use Intl.DateTimeFormat for aria-labels" #8436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ria-labe…" This reverts commit e77c513.
|
web-padawan
approved these changes
Jan 3, 2025
web-padawan
deleted the
revert-8433-refactor/use-intl-to-format-aria-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to revert #8433 because using
Intl.DateTimeFormatwith thelocalei18n property requires more thorough consideration. For example, it's unclear whether thelocaleproperty should be optional or mandatory, and if it's optional, what the default value should be (browser's locale? html tag lang?).Ticket #3385