Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace h5 in login error message with strong (#8438) (CP: 24.6) #8439

Merged
merged 1 commit into from
Jan 3, 2025
+14 −9
Merged

refactor: replace h5 in login error message with strong (#8438) (CP: 24.6) #8439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/login/src/vaadin-lit-login-form-wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class LoginFormWrapper extends ThemableMixin(PolylitMixin(LitElement)) {
<section part="form">
<h2 part="form-title">${this.i18n.form.title}</h2>
<div part="error-message" ?hidden="${!this.error}">
<h5 part="error-message-title">${this.i18n.errorMessage.title}</h5>
<strong part="error-message-title">${this.i18n.errorMessage.title}</strong>
<p part="error-message-description">${this.i18n.errorMessage.message}</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/login/src/vaadin-login-form-wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class LoginFormWrapper extends ThemableMixin(PolymerElement) {
<section part="form">
<h2 part="form-title">[[i18n.form.title]]</h2>
<div part="error-message" hidden$="[[!error]]">
<h5 part="error-message-title">[[i18n.errorMessage.title]]</h5>
<strong part="error-message-title">[[i18n.errorMessage.title]]</strong>
<p part="error-message-description">[[i18n.errorMessage.message]]</p>
</div>
Expand Down
12 changes: 6 additions & 6 deletions packages/login/test/dom/__snapshots__/login-form.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,9 +580,9 @@ snapshots["vaadin-login-form shadow default"] =
hidden=""
part="error-message"
>
<h5 part="error-message-title">
<strong part="error-message-title">
Incorrect username or password
</h5>
</strong>
<p part="error-message-description">
Check that you have entered the correct username and password and try again.
</p>
Expand Down Expand Up @@ -611,9 +611,9 @@ snapshots["vaadin-login-form shadow error"] =
Log in
</h2>
<div part="error-message">
<h5 part="error-message-title">
<strong part="error-message-title">
Incorrect username or password
</h5>
</strong>
<p part="error-message-description">
Check that you have entered the correct username and password and try again.
</p>
Expand Down Expand Up @@ -645,9 +645,9 @@ snapshots["vaadin-login-form shadow i18n"] =
hidden=""
part="error-message"
>
<h5 part="error-message-title">
<strong part="error-message-title">
Väärä käyttäjätunnus tai salasana
</h5>
</strong>
<p part="error-message-description">
Tarkista että käyttäjätunnus ja salasana ovat oikein ja yritä uudestaan.
</p>
Expand Down
2 changes: 2 additions & 0 deletions packages/login/theme/lumo/vaadin-login-form-wrapper-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,10 @@ const loginFormWrapper = css`
}
[part='error-message-title'] {
display: block;
margin: 0 0 0.25em;
color: inherit;
line-height: var(--lumo-line-height-xs);
}
[part='error-message-description'] {
Expand Down
5 changes: 4 additions & 1 deletion packages/login/theme/material/vaadin-login-form-wrapper-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,12 @@ const loginFormWrapper = css`
margin-right: calc(2.25rem * -0.95);
}
[part='error-message'] h5 {
[part='error-message-title'] {
display: block;
margin: 0 0 0.25em;
color: inherit;
line-height: 1.1;
text-indent: -0.025em;
}
[part='error-message'] p {
Expand Down