Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for \cpageref, \labelcref and variants #266

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

loicreynier
Copy link

@loicreynier loicreynier commented Jul 27, 2023

This adds support for the \cpageref, \cpagerefrange, \labelcrefand \labelcpageref commands of the cleveref package. The main command, \cref, already had support. I used the same line as in the \cref support, that is:

LatexCommandSignature("\\cpagerefrange{}{}", LatexCommandSignature.Action.Dummy),

If I understand correctly, LatexCommandSignature.Action.Dummy raises a dummy warning when the command is parsed by replacing the command by Jimmyin the text. I am not sure if this should be the default behavior for those commands that are used a lot in documents.

Edit

I just understood the relevance of replacing with Jimmy. It is necessary to replace the command with a term to avoid gaps in the sentences that would also lead to errors.
Jimmy works very well in English, but in French, as we often add a gendered determinant before commands of the type cref, it is less versatile and leads to a concordance error.

@spitzerd
Copy link

spitzerd commented Dec 8, 2024

Your commit was merged into ltex-ls-plus:
ltex-plus@8b881b3

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants